[cxx-interop] Fix a regression making std::string unsafe #80305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only get warnings for using unsafe types in expressions but not in the function signature. The tests did not use the std::string object in the function body. As a result, we regressed and std::string was considered unsafe. The reason is that the annotation only mode for calculating escapability of a type did not do what we intended. std::basic_string is conditionally escapable if the template argument is escapable. We considered 'char' to have unknown escapability in annotation only mode. The annotation only mode was introduced to avoid suddenly importing certain types as not escapable when they have pointer fields and break backward compatibility. The solution is to make annotation only mode to still consider char and co as escapable types and only fall back to unknown when the inference otherwise would have deduced non-escapable (for unannotated typed).
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only get warnings for using unsafe types in expressions but not in the function signature. The tests did not use the std::string object in the function body. As a result, we regressed and std::string was considered unsafe.
The reason is that the annotation only mode for calculating escapability of a type did not do what we intended. std::basic_string is conditionally escapable if the template argument is escapable. We considered 'char' to have unknown escapability in annotation only mode. The annotation only mode was introduced to avoid suddenly importing certain types as not escapable when they have pointer fields and break backward compatibility.
The solution is to make annotation only mode to still consider char and co as escapable types and only fall back to unknown when the inference otherwise would have deduced non-escapable (for unannotated types).