[Swiftify] Fix transformation sort, and dropped bounds checks #80317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
DougGregor
approved these changes
Mar 26, 2025
Xazax-hun
approved these changes
Mar 26, 2025
When an imported function combines std::span and __counted_by, std::span would override bounds checks emitted for __counted_by (if it occurred later in the the parameter list) resulting in no bounds checks being emitted. rdar://147883384
Casting the return value to Span must be done outside withUnsafeBufferPointer, to prevent returning a ~Escapable type from a function without lifetime info. To do this we sort the transformations so that the return value transformation is performed last. There was a bug in the comparison, so the sorting was not always done correctly. rdar://147934170
hnrklssn
force-pushed
the
fix-sort-and-bounds-checks
branch
from
d056383 to
160bb41
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Swiftify] Fix return value transformation being applied last
Casting the return value to Span must be done outside
withUnsafeBufferPointer, to prevent returning a ~Escapable type from a
function without lifetime info. To do this we sort the transformations
so that the return value transformation is performed last. There was
a bug in the comparison, so the sorting was not always done correctly.
rdar://147934170
[Swiftify] Don't drop bounds checks when mixing std::span and counted_by
When an imported function combines std::span and __counted_by,
std::span would override bounds checks emitted for __counted_by (if it
occurred later in the the parameter list) resulting in no bounds checks
being emitted.
rdar://147883384