A couple of SourceRange fixes for nonisolated
#80345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@hamishknight I do have a test-case :) This is a reduction from rdar://147965036 |
xedin
approved these changes
Mar 27, 2025
Funnily enough that's actually a different issue since it's a decl attribute there 😄 I see the issue, I can put up a fix for it |
|
Heh, thanks! |
hamishknight
force-pushed
the
nonisolated-range
branch
from
68f8747 to
c8d7db8
Compare
hamishknight
requested review from
ktoso,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
Attributes like `nonisolated` aren't spelled with an `@`. I don't have a test case, but this would assert if the source range were queried.
Avoid printing a spurious space when not printing the `attribute` branch of this diagnostic.
Make sure we set the `AttrRange` in cases where `@` is present, but `unsafe` isn't present. rdar://147965036
hamishknight
force-pushed
the
nonisolated-range
branch
from
c8d7db8 to
42e554e
Compare
|
Updated with the fix for rdar://147965036 |
|
@swift-ci please smoke test |
hamishknight
changed the title
@ location in AtTypeAttrBasenonisolated
ahoppen
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonisolatedaren't spelled with an@, make sure the type attribute logic handles a missing@. I don't have a test case for this, but this would assert if the source range were queried.@.rdar://147965036