[IRGen] Fix non-deterministic requests in addAbstractForFulfillments() #80370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `addAbstractForFulfillments()`, FulfillmentMap (DenseMap) is iterated to compute all the cache entries. Even the non-deterministic iteration order doesn't affect the computed cache entries, the requests to the evaluator during the process will be in non-deterministic order. This will cause the fine-grain dependency file generated to be non-deterministic. Use a `MapVector` to make sure iteration order is deterministic. rdar://147971980
cachemeifyoucan
force-pushed
the
eng/PR-147971980
branch
from
4f5c56e to
cdf881f
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
addAbstractForFulfillments(), FulfillmentMap (DenseMap) is iterated to compute all the cache entries. Even the non-deterministic iteration order doesn't affect the computed cache entries, the requests to the evaluator during the process will be in non-deterministic order. This will cause the fine-grain dependency file generated to be non-deterministic. Use aMapVectorto make sure iteration order is deterministic.rdar://147971980