[concurrency] Fix a few issues with @execution(caller)/@execution(concurrent). #80374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just makes it easier to work with these types in the debugger. Just slicing off commits from a larger patch.
gottesmm
requested review from
ktoso,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
xedin
reviewed
Mar 28, 2025
gottesmm
force-pushed
the
pr-ee297e6b432cd07483ec86444ffd6a8b5334c203
branch
from
9cf8672 to
e88ec99
Compare
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-ee297e6b432cd07483ec86444ffd6a8b5334c203
branch
from
e88ec99 to
4733133
Compare
|
@swift-ci smoke test |
…current). Specifically: 1. I made it so that thunks from caller -> concurrent properly ignore the isolated parameter of the thunk when calling the concurrent function. rdar://148112362 2. I made it so that thunks from concurrent -> caller properly create a Optional<any Actor>.none and pass that into the caller function. rdar://148112384 3. I made it so that in cases where we are assigning an @sendable caller to a non-sendable caller variable, we allow for the conversion as long as the parameters/results are sendable as well. rdar://148112532 4. I made it so that when we generate a thunk from @execution(caller) -> @GlobalActor, we mangle in @GlobalActor into the thunk. rdar://148112569 5. I discovered that due to the way we handle function conversion expr/decl ref expr, we were emitted two thunks when we assigned a global @caller function to a local @caller variable. The result is that we would first cast from @caller -> @Concurrent and then back to @caller. The result of this would be that the @caller function would always be called on the global queue. rdar://148112646 I also added a bunch of basic tests as well that showed that this behavior was broken.
gottesmm
force-pushed
the
pr-ee297e6b432cd07483ec86444ffd6a8b5334c203
branch
from
4733133 to
f245389
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
isolated parameter of the thunk when calling the concurrent function.
rdar://148112362
Optional.none and pass that into the caller function.
rdar://148112384
non-sendable caller variable, we allow for the conversion as long as the
parameters/results are sendable as well.
rdar://148112532
@GlobalActor, we mangle in @GlobalActor into the thunk.
rdar://148112569
expr, we were emitted two thunks when we assigned a global @caller function to a
local @caller variable. The result is that we would first cast from @caller ->
@Concurrent and then back to @caller. The result of this would be that the
@caller function would always be called on the global queue.
rdar://148112646
I also added a bunch of basic tests as well that showed that this behavior was
broken.
I did these in the same PR since I was basically iterating on writing simple code and found these issues. I have found some more issues that I am going to keep iterating/fixing.