[DebugInfo] Use underlying type of global variables with opaque type #80380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
slavapestov
reviewed
Mar 31, 2025
lib/IRGen/IRGenDebugInfo.cpp
Outdated
| @@ -3869,6 +3869,14 @@ void IRGenDebugInfoImpl::emitGlobalVariableDeclaration( | |||
| if (Opts.DebugInfoLevel <= IRGenDebugInfoLevel::LineTables) | |||
| return; | |||
|
|
|||
| // If this global variable contains an opaque type, replace it with its | |||
| // underlying type. | |||
| if (auto UnderlyingType = IGM.substOpaqueTypesWithUnderlyingTypes( | |||
There was a problem hiding this comment.
substOpaqueTypesWithUnderlyingTypes never returns null, so this if statement is always taken
There was a problem hiding this comment.
And it's a noop for all other types?
lib/IRGen/IRGenDebugInfo.cpp
Outdated
| if (auto UnderlyingType = IGM.substOpaqueTypesWithUnderlyingTypes( | ||
| DbgTy.getType()->getCanonicalType())) { | ||
| auto &TI = IGM.getTypeInfoForUnlowered(UnderlyingType); | ||
| DbgTy = DebugTypeInfo::getFromTypeInfo(UnderlyingType, TI, IGM); |
There was a problem hiding this comment.
I guess we still don't want to do this all the time.
adrian-prantl
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://144881938