Skip to content

[Concurrency] When expanding #isolation create a type-checked type expr for global actors. #80382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

hborla
Copy link
Member

@hborla hborla commented Mar 28, 2025

This eliminates a crash when type checking #isolation expansions for global actors nested in other types, because the TypeExpr does not properly represent the type repr for nested types. It's simpler to provide the type directly instead of going through type resolution.

Resolves: rdar://136028459

expr for global actors.

This eliminates a crash when type checking `#isolation` expansions
for global actors nested in other types, because the `TypeExpr`
does not properly represent the type repr for nested types. It's
simpler to provide the type directly instead of going through type
resolution.
@hborla
Copy link
Member Author

hborla commented Mar 28, 2025

@swift-ci please smoke test

@hborla hborla merged commit 68b95f8 into swiftlang:main Mar 29, 2025
3 checks passed
@hborla hborla deleted the isolation-crash branch March 29, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant