Skip to content

Platform: add APINotes for bionic.spawn #80386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

Add some APINotes for bionic.spawn to correct the nullability annotations. This allows building Foundation with NDK r26b.

(cherry picked from commit c4f5831)

Add some APINotes for `bionic.spawn` to correct the nullability
annotations. This allows building Foundation with NDK r26b.

(cherry picked from commit c4f5831)
@compnerd compnerd requested a review from a team as a code owner March 29, 2025 03:42
@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@shahmishal
Copy link
Member

@swift-ci build toolchain windows

@compnerd
Copy link
Member Author

  • Explanation:
    Add additional API Notes to adjust system APIs on Android to correct nullability annotations.
  • Scope:
    This change is required to allow building the SDK against the supported NDK. It simply adds an additional file to the installed image for Android:
  • Issues:
  • Original PRs:
    Platform: add APINotes for bionic.spawn #79687
  • Risk:
    Extremely low risk - build rules only change to add a text file to the installed image for Android only.
  • Testing:
    Build test with the change.
  • Reviewers:

@compnerd compnerd closed this Apr 8, 2025
@compnerd compnerd deleted the 61-bionic branch April 8, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants