Skip to content

[ASTScope] Upgrade checkSourceRangeBeforeAddingChild to conditional assert #80401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
+2 −3
Merged

[ASTScope] Upgrade checkSourceRangeBeforeAddingChild to conditional assert #80401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/AST/ASTScopeCreation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,8 @@ void ASTScopeImpl::addChild(ASTScopeImpl *child, ASTContext &ctx) {
ASTScopeAssert(!child->getParent(), "child should not already have parent");
child->parentAndWasExpanded.setPointer(this);

#ifndef NDEBUG
checkSourceRangeBeforeAddingChild(child, ctx);
#endif
if (CONDITIONAL_ASSERT_enabled())
checkSourceRangeBeforeAddingChild(child, ctx);

// If this is the first time we've added children, notify the ASTContext
// that there's a SmallVector that needs to be cleaned up.
Expand Down