Skip to content

Tests: enable Swift PM tests in Windows toolchain build #80405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Tests: enable Swift PM tests in Windows toolchain build #80405

merged 1 commit into from
Jun 10, 2025

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Mar 31, 2025 •
edited
Loading

Enable the SwiftPM tests in the Windows toolchain build to get extra confidence the change did not introduce any regression on the Windows platform.

Requires: swiftlang/swift-package-manager#8601
Requires: swiftlang/swift-package-manager#8759

@bkhouri bkhouri force-pushed the t/main/update_swiftpm_presets branch from 858d248 to 3516197 Compare March 31, 2025 14:15
@bkhouri bkhouri mentioned this pull request Mar 31, 2025
Closed
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

duplicate of #71349 (I did not have permissions to update the source branch)

@bkhouri bkhouri marked this pull request as ready for review April 8, 2025 20:26
@bkhouri bkhouri requested a review from compnerd as a code owner April 8, 2025 20:26
compnerd
compnerd approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is happy, I think that this is good

@bkhouri bkhouri enabled auto-merge April 9, 2025 19:14
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 10, 2025

@swift-ci test windows

@bkhouri bkhouri force-pushed the t/main/update_swiftpm_presets branch from 3516197 to ca0787f Compare April 21, 2025 17:55
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 21, 2025

@swift-ci please smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 22, 2025

@compnerd : enabling the swiftpm tests in the build.ps1 has some test failures, which are not observed with the self hosted windows pipeline, which run inside a docker image.

Do you have any thoughts/ideas why the two would be different, and how we can closer align the test status between the two?

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 27, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 28, 2025

@swift-ci please smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 29, 2025

@swift-ci smoke test

@bkhouri bkhouri requested a review from shahmishal April 29, 2025 17:08
This was referenced May 1, 2025
Closed
Merged
@bkhouri
Copy link
Contributor Author

bkhouri commented May 1, 2025

swiftlang/swift-package-manager#8601

@swift-ci smoke test

bkhouri added a commit to swiftlang/swift-package-manager that referenced this pull request May 1, 2025
@bkhouri
Tests: Conditionally skip the Archiver tests (#8601)
c5582fb 
The Archiver tests has a dependency on a system binary being available
on the host. Update the archiver test to skip the test is the required
executable is not available on the system.

Fixes: #8586
Issue: rdar://150414402
Required for: swiftlang/swift#80405
@bkhouri
Copy link
Contributor Author

bkhouri commented May 15, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented May 16, 2025

@swift-ci smoke test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 2, 2025

@swift-ci test windows

@bkhouri bkhouri self-assigned this Jun 2, 2025
@bkhouri bkhouri mentioned this pull request Jun 3, 2025
Merged
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 3, 2025

swiftlang/swift-package-manager#8759

@swift-ci test windows

@bkhouri bkhouri disabled auto-merge June 4, 2025 18:20
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 4, 2025

swiftlang/swift-package-manager#8759

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 5, 2025

swiftlang/swift-package-manager#8759

@swift-ci test windows

@bkhouri bkhouri force-pushed the t/main/update_swiftpm_presets branch from ca0787f to 4b0125f Compare June 5, 2025 13:35
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 5, 2025

swiftlang/swift-package-manager#8759

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 5, 2025

swiftlang/swift-package-manager#8759

@swift-ci smoke test

3 similar comments
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 6, 2025

swiftlang/swift-package-manager#8759

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 6, 2025

swiftlang/swift-package-manager#8759

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 6, 2025

swiftlang/swift-package-manager#8759

@swift-ci smoke test

@bkhouri bkhouri marked this pull request as draft June 9, 2025 15:50
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 9, 2025 •
edited
Loading

Converted this PR back to draft as I want to trigger CI-builds once swiftlang/swift-package-manager#8759 is merged to gain more confidence with this change.

The cross-repository testing was successful when tested with swiftlang/swift-package-manager#8759.

Screenshot 2025-06-09 at 4 01 42 PM

@bkhouri
Tests: enable Swift PM tests in Windows toolchain build
5b4016e 
Enable the SwiftPM tests in the WIndows toolchain build to get extra
confidence the change did not introduce any regression on the Windows
platform.
@bkhouri bkhouri force-pushed the t/main/update_swiftpm_presets branch from 4b0125f to 5b4016e Compare June 9, 2025 20:03
bkhouri added a commit to swiftlang/swift-package-manager that referenced this pull request Jun 9, 2025
@bkhouri
Disable some tests when running on Windows platform smoke test (#8759)
00bfa31 
Required for swiftlang/swift#80405
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 10, 2025

@swift-ci smoke test

@bkhouri bkhouri marked this pull request as ready for review June 10, 2025 03:07
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 10, 2025

@swift-ci test linux

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 10, 2025

@swift-ci smoke test linux

@bkhouri bkhouri merged commit 9c3143d into swiftlang:main Jun 10, 2025
4 checks passed
@bkhouri bkhouri deleted the t/main/update_swiftpm_presets branch June 10, 2025 17:55
This was referenced Jun 16, 2025
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees

@bkhouri bkhouri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkhouri @compnerd @shahmishal