[AST] Remove AccessorDecl handling from getSourceRangeIncludingAttrs
#80407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem like this is necessary anymore since we no longer clone OverrideAttrs when checking overrides (except when invalidating). Moreover, it's now actively wrong since accessors introduced by macro expansions may be in different buffers than their their storage, so checking `isBeforeInBuffer` will non-deterministically result in the wrong source range.
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
rintaro
approved these changes
Apr 1, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem like this is necessary anymore since we no longer clone OverrideAttrs when checking overrides (except when invalidating). Moreover, it's now actively wrong since accessors introduced by macro expansions may be in different buffers than their their storage, so checking
isBeforeInBufferwill non-deterministically result in the wrong source range.I'm hoping to add an assertion to
isBeforeInBuffer(#80402), which caught this.