Distributed: Fix a -Wparentheses warning
#80450
Conversation
tshortli
requested review from
ktoso,
slavapestov,
hborla and
xedin
as code owners
|
@swift-ci please smoke test |
|
@ktoso Let me know if you think something else should be done to resolve this. |
|
It’s NOT safe to just ignore this and the code where we’re not strictly ordered must be fixed. It’s on my queue but behind other tasks. here’s my PR about it which will need more work to fix the root cause: #79146 so let’s close this and I’ll get around to it soon. thank you for the ping though, yes we gotta fix that |
|
Can we at least remove (or comment out) the code that triggers the warning in the meantime so as not to spam? |
The following warning was being emitted by newer versions of clang: ``` comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses] ``` This code needs to be reworked to ensure that the conditions that are meant to be asserted are true.
tshortli
force-pushed
the
fix-parentheses-warning
branch
from
db81c77 to
8819d6d
Compare
|
I pushed a new version that is just a FIXME and commenting out the assertion. |
|
@swift-ci please smoke test |
|
Heh, given we have tons of other warnings not sure this is going to push the needle much on warningless build but okey we can move to a FIXME since the assertion doesn't really work anyway. LGTM |
|
I've been fixing all the warnings, that's why I'd really like to squash this one. Thanks! |
|
@swift-ci please smoke test macOS |
The following warning was being emitted by newer versions of clang:
This code needs to be reworked to ensure that the conditions that are meant to be asserted are true.