[Distributed] Harden detecting adhoc req methods #80459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing protocol decls
This issue manifested in crashing when in Xcode one would do the Archive
workflow, and we would be missing the Distributed module types and
proceed to run into a nullpointer when faced with code like this:
```
public class TestViewModel {
public init() {}
public func onReturn() {
print("on return executed!")
}
}
```
where the name matched one of the ad hoc requirements, but we'd get null
for the protocol lookup since this does not import the distributed
module.
resolves rdar://148327936
ktoso
force-pushed
the
wip-dontcrash-on-missing-type-when-detecting-distributed-adhoc-reqs
branch
from
f3ea823 to
6ca5ace
Compare
ktoso
changed the title
|
@swift-ci please smoke test |
ktoso
deleted the
wip-dontcrash-on-missing-type-when-detecting-distributed-adhoc-reqs
branch
|
Thank you for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't crash when missing protocol decls.
This issue manifested in crashing when in Xcode one would do the Archive workflow, and we would be missing the Distributed module types and proceed to run into a nullpointer when faced with code like this:
where the name matched one of the ad hoc requirements, but we'd get null for the protocol lookup since this does not import the distributed module.
resolves rdar://148327936
*I could not figure how to replicate the "Archive" behavior even though copying the exact command Xcode was doing hmm...