Skip to content

[6.1] Fix missing refs to accesor when shadowing with if-let shorthand. #80464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[6.1] Fix missing refs to accesor when shadowing with if-let shorthand. #80464

merged 1 commit into from
Apr 4, 2025
+10 −5

Conversation

hamishknight
Copy link
Contributor

6.1 cherry-pick of #80444

  • Explanation: Fixes an issue where local rebindings of properties lost the corresponding reference in the index store
  • Scope: Affects indexing
  • Issue: rdar://148438088
  • Risk: Low, the fix is straightforward and restores the behavior prior to 6.1
  • Testing: Added tests to test suite
  • Reviewer: Ben Barham

@dylansturg @hamishknight
Fix missing refs to accesor when shadowing with if-let shorthand.
c6a5321 
After swiftlang@ce55a85 the references to accessors for the shadowed accessor were discarded when indexing without locals.
@hamishknight hamishknight added the 🍒 release cherry pick Flag: Release branch cherry picks label Apr 2, 2025
@hamishknight hamishknight requested a review from bnbarham April 2, 2025 16:54
@hamishknight hamishknight requested a review from a team as a code owner April 2, 2025 16:54
@hamishknight
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@bnbarham
Copy link
Contributor

bnbarham commented Apr 2, 2025

@swift-ci please test

@hamishknight hamishknight merged commit 954c668 into swiftlang:release/6.1 Apr 4, 2025
5 checks passed
@hamishknight hamishknight deleted the index-6.1-cherry-pick branch April 4, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamishknight @bnbarham @airspeedswift @dylansturg