[Driver] Don't hardcode default linker on Linux #80479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the C++ driver counterpart to a change that landed in the Swift driver a while ago to use the clang-linker to determine what the default linker is. This is to avoid hard-coding gold, which is deprecated and not available on some newer Linux distributions. The challenge is that these newer Linux distributions don't already have Swift so we have to use the old C++ driver implementation.
|
@swift-ci please test |
finagolfin
approved these changes
Apr 3, 2025
|
@swift-ci test macos |
artemcm
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the C++ driver counterpart to a change that landed in the Swift driver a while ago to use the clang-linker to determine what the default linker is. This is to avoid hard-coding gold, which is deprecated and not available on some newer Linux distributions. The challenge is that these newer Linux distributions don't already have Swift so we have to use the old C++ driver implementation.