AST: Simplify ProtocolConformanceRef operations a little bit #80482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atedConformance()
We implement getIdentitySubstitutionMap() by passing in a no-op substitution callback. Remove the unnecessary getCanonicalType() call, to ensure that the abstract conformance in the identity substitution map uses the sugared form of the subject type.
slavapestov
force-pushed
the
abstract-conformance-cleanup
branch
from
97ae154 to
e475b08
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
requested review from
AnthonyLatsis,
hborla,
xedin,
eeckstein,
jckarter,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui and
fahadnayyar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @DougGregor's PR #80225, abstract conformances now store their conforming type. This means we no longer have to pass it around separately in various places that operate on
ProtocolConformanceRef.Now,
ProtocolConformanceRefandProtocolConformanceexpose the same fundamental set of operations:getType()getProtocol()subst(SubstitutionMap)getTypeWitness(AssociatedTypeDecl *)getAssociatedConformance(CanType, ProtocolDecl *)The ProtocolConformanceRef variants of the last three used to also take an
origTypeparameter, which was supposed to be the conforming type of the abstract conformance. This made them difficult and error-prone to use. All of this book-keeping is now gone.