Skip to content

[cxx-interop] Add test case that checks irgen for imported private members #80515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Apr 3, 2025

Cleans up an existing test case for private members + adds a new one

@j-hui
Copy link
Contributor Author

j-hui commented Apr 3, 2025

@swift-ci please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test

1 similar comment
@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a nit.

@j-hui j-hui force-pushed the test-private-irgen branch 2 times, most recently from 2a1926a to dfff952 Compare April 4, 2025 16:44
@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Apr 4, 2025

@swift-ci please smoke test windows platform

2 similar comments
@j-hui
Copy link
Contributor Author

j-hui commented Apr 5, 2025

@swift-ci please smoke test windows platform

@j-hui
Copy link
Contributor Author

j-hui commented Apr 5, 2025

@swift-ci please smoke test windows platform

@j-hui j-hui force-pushed the test-private-irgen branch from b45c4b0 to 040ca6f Compare April 6, 2025 03:26
@j-hui
Copy link
Contributor Author

j-hui commented Apr 6, 2025

@swift-ci please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Apr 7, 2025

@swift-ci please smoke test

@j-hui
Copy link
Contributor Author

j-hui commented Apr 7, 2025

@swift-ci please smoke test windows platform

@j-hui j-hui force-pushed the test-private-irgen branch from 4ab1165 to e3cf1cc Compare April 8, 2025 23:25
@j-hui
Copy link
Contributor Author

j-hui commented Apr 8, 2025

@swift-ci please smoke test

@j-hui j-hui merged commit ce680ea into swiftlang:main Apr 9, 2025
3 checks passed
@j-hui j-hui deleted the test-private-irgen branch April 9, 2025 18:05
j-hui added a commit to j-hui/swift that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants