[stdlib] Reinstate AllowUnsafeAttribute experimental feature on libraries #80518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries We need this so that older compilers can handle the .swiftinterface files we generate. It's unnecessary for newer compilers and can be removed later. Fixes rdar://148529962.
DougGregor
requested review from
ktoso,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
a team,
tshortli,
etcwilde,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
tshortli
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
It's hard to ensure that we do this systematically, but one thing I've been doing recently is preemptively relaxing experimental feature checks in the context of swiftinterface files to avoid this problem. Usually it's only important to enforce them in source.
|
I wish past-me had thought to do this :) |
etcwilde
approved these changes
Apr 4, 2025
|
@swift-ci please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this so that older compilers can handle the .swiftinterface files we generate. It's unnecessary for newer compilers and can be removed later.
Fixes rdar://148529962.