[CoroutineAccessors] Use async bit in descriptors. #80520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate back deployment, make use of the fact that the async bit has up to now never been set for read and modify accessors and claim that set bit to indicate that it is a callee-allocated coroutine. This has the virtue of being completely back deployable because like async function pointers coro function pointers must be auth'd and signed as data.
|
@swift-ci please test |
|
@swift-ci please test windows platform |
nate-chandler
requested review from
mikeash,
al45tair and
rjmccall
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate back deployment, make use of the fact that the async bit has up to now never been set for read and modify accessors and claim that set bit to indicate that it is a callee-allocated coroutine. This has the virtue of being completely back deployable because like async function pointers coro function pointers must be auth'd and signed as data.