AST: Cut down on DescriptiveDeclKind usage in diagnostics
#80524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
ktoso,
xymus,
tshortli,
kavon,
eeckstein,
jckarter,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test macOS |
ktoso
approved these changes
Apr 4, 2025
AnthonyLatsis
force-pushed
the
diag-descriptive-decl-kind
branch
from
4814f91 to
cfa4074
Compare
|
@swift-ci please smoke test macOS |
xedin
approved these changes
Apr 5, 2025
|
Yes, while splitting @execution into multiple attributes I ran into out inability to use TypeAttribute which is pretty restrictive. |
This is the desired behavior is most cases. In the future, we should consider adding format specifiers for short/detailed descriptions.
This is the desired behavior is most cases. In the future, we should consider adding format specifiers for short/detailed descriptions.
AnthonyLatsis
force-pushed
the
diag-descriptive-decl-kind
branch
from
cfa4074 to
5c190b9
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use format specifiers instead and trust the engine to call
getDescriptiveKind()and do its thing. The remaining few diagnostics that acceptDescriptiveDeclKindwill require more work.Includes #80473 to avoid conflicts.