[6.2][Distributed] Fix distributed accessors for resilient modules #80574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
wip-pickwip-tapi-validation
branch
from
3caad6d to
9c8c2f8
Compare
This is an important fix for libraries using @resolvable in resilient libraries. Without the fix we're missing an accessor and this will fail some remote calls which make use of remote calls on resolvable protocols. This would manifest as missing accessor error thrown by the executeDistributedTarget function. resolves rdar://148224780
This resolves pedantic "all" TBD validation issues, i.e. we dont emit unexpected records anymore - we would before as we only checked for is_distributed but we also want to skip those for is_distributed_thunk resolves rdar://128284016
ktoso
force-pushed
the
wip-pickwip-tapi-validation
branch
from
9c8c2f8 to
eca421d
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
hborla
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Scope/Impact: Projects using Distributed can use pedantic/all TBD verification mode.
Risk: Low. Makes sure accessors are emitted also in resilient mode and corrects the same in TBD.
Testing: Added reproducer for the issue to test suite
Reviewed by: @xedin
Original PR: #80526 #80523
Radar: rdar://128284016 rdar://148224780