[6.2][cxx-interop] Fix not importing return type for certain functions #80585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: Fixes that functions imported from C++ namespaces are taking a different code path than functions importing from the global namespace. This also fixes an error where the return type of a templated function is sometimes not imported. Scope: C++ forward interop. Issue: rdar://148735986 Risk: Low, the fix is targeted to make C++ functions in namespaces take a well tested code path that we already use for C++ functions in the global scope. Testing: Added tests to test suite Reviewer: John Hui
Xazax-hun
added
c++ interop
|
@swift-ci please test |
airspeedswift
approved these changes
Apr 8, 2025
j-hui
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes that functions imported from C++ namespaces are taking a different code path than functions importing from the global namespace. This also fixes an error where the return type of a templated function is sometimes not imported.
Scope: C++ forward interop.
Issue: rdar://148735986
Risk: Low, the fix is targeted to make C++ functions in namespaces take a well tested code path that we already use for C++ functions in the global scope.
Testing: Added tests to test suite
Reviewer: @j-hui