[6.1.1][SILOptimizer] Prevent devirtualization of call to distributed witness requirements #80637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s requirements This is a narrow fix, we are going to work on fixing this properly and allowing both devirtualization and specialization for distributed requirement witnesses. Anything that uses an ad-hoc serialization requirement scheme cannot be devirtualized because that would result in loss of ad-hoc conformance in new substitution map. Resolves: swiftlang#79318 Resolves: rdar://146101172 (cherry picked from commit 0415b40)
|
@swift-ci please test |
airspeedswift
approved these changes
Apr 8, 2025
|
Failure was unrelated: Python/python_lint.swift |
|
@swift-ci please test macOS |
|
Pending on #80699 which will unbreak CI |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #80373
Explanation:
Fixes a crash in optimized mode related to use of distributed requirements.
This is a narrow fix, we are going to work on fixing this properly and allowing both devirtualization and specialization for distributed requirement witnesses.
Anything that uses an ad-hoc serialization requirement scheme cannot be devirtualized because that would result in loss of ad-hoc conformance in new substitution map.
Main Branch PR: [SILOptimizer] Prevent devirtualization of call to distributed witnes… #80373
Risk: Very low (narrow fix that only affects uses of witnesses to distributed requirements with ad-hoc serialization requirement).
Resolves: Assertion failure swift::ProtocolConformanceRef::subst with 6.1 in release build #79318
Resolves: rdar://146101172
Reviewed By: @slavapestov
Testing: Added new tests to the Distributed test suite.
(cherry picked from commit 0415b40)