[6.2] Serialization: Encode custom availability domains #80641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#import` directive is not supported by Clang in MSVC compatibility mode, so use `#include` instead for compatibility in the ClangImporter tests for custom availability domains. Resolves rdar://147122406.
Partially revert swiftlang#80035 now that Clang has its own APIs for querying serialized modules for the decl representing the availability domain with a given name.
When serializing `@available` attributes, if the attribute applies to a custom domain include enough information to deserialize the reference to that domain. Resolves rdar://138441265.
tshortli
force-pushed
the
availability-domain-serialization-6.2
branch
from
a587891 to
38e56fc
Compare
|
@swift-ci please test |
nkcsgexi
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@availableattributes, if the attribute applies to a custom domain include enough information to deserialize the reference to that domain. Additionally, remove the now unnecessary ClangImporter Swift lookup table support for availability domains. Clang now handles looking up serialized availability domain declarations in precompiled modules itself. Finally, when printing.swiftinterfacefiles, guard declarations that use theCustomAvailabilityfeature.@availableattributes.CustomAvailabilityis enabled, and there are no adopters. The serialization format changes to accommodate custom domains will always be active, but serializing and deserializing existing kinds ofAvailableAttris very well tested by the standard library build and test suite.