Skip to content

[SR-4219] Resolve non-deterministic compiler crashes #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2017
Merged

[SR-4219] Resolve non-deterministic compiler crashes #8066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...uted-at-swift-lib-ast-type-cpp-1344.swift → ...uted-at-swift-lib-ast-type-cpp-1344.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior

// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
func b(UInt=1 + 1 as?Int){$
5 changes: 2 additions & 3 deletions ...cantype-out-of-a-non-canonical-type.swift → ...cantype-out-of-a-non-canonical-type.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: asserts
// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{func b(UInt=1 + 1 as?Int){f

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blame resolve-crashes 😇

In reality it changes nothing. The important thing in this crash is that we typecheck b as a function and look into its parameter list to validate types.

4 changes: 1 addition & 3 deletions ...s/28665-result-case-not-implemented.swift → ...d/28665-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: asserts
// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{func a(UInt=1 + 1 + 1 as?Int){
typealias e:A(t:_
func a{
Expand Down
3 changes: 1 addition & 2 deletions ...s/28667-result-case-not-implemented.swift → ...d/28667-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{extension{{}func b(UInt=_=1 + 1 as?Int){(==S
class d
func b(=_{$0=a(ol a=a(
4 changes: 1 addition & 3 deletions ...s/28672-result-case-not-implemented.swift → ...d/28672-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
a
V!in{
class B{func b(UInt=1 + 1 + 1 as?Int)
Expand Down
3 changes: 1 addition & 2 deletions ...673-swift-typebase-getcanonicaltype.swift → ...673-swift-typebase-getcanonicaltype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior

// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
class C{}@&{
func b(UInt=1 + 1 + 1 as?Int){
f=a=Aay=b
Expand Down
3 changes: 1 addition & 2 deletions ...675-swift-typebase-getdesugaredtype.swift → ...675-swift-typebase-getdesugaredtype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir

// REQUIRES: deterministic-behavior
Int)func b(UInt=1 + 1 + 1 + 1 as?Int){{{{{{{{{{{{{a{
4 changes: 1 addition & 3 deletions ...s/28678-result-case-not-implemented.swift → ...d/28678-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
[{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{func b(UInt=1 + 1 as?Int){{{{{ }struct c=1 + 1 + 1 as?Int){{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
[.==A{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
3 changes: 1 addition & 2 deletions ...680-swift-typebase-getdesugaredtype.swift → ...680-swift-typebase-getdesugaredtype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
(_
func t(UInt=1 + 1 + 1 + 1 as?Int){{{{{{{{{{{{{h{
4 changes: 1 addition & 3 deletions ...s/28683-result-case-not-implemented.swift → ...d/28683-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{func t(UInt=_=1 + 1 as?Int){{{{{{{{y v
3 changes: 1 addition & 2 deletions ...uted-at-swift-lib-ast-type-cpp-1344.swift → ...uted-at-swift-lib-ast-type-cpp-1344.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{{{{+1 as?Int{{func b(UInt=1 + 1 + 1 + 1 as?Int){{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{t =={t(h{{{{{{{{{{{{{{{{f{
3 changes: 1 addition & 2 deletions ...686-swift-typebase-getcanonicaltype.swift → ...686-swift-typebase-getcanonicaltype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
protocol A.{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{let f&(a=a?Int){{{{{{{{{{{{{{{{{{{{{{{{{{{(_
}
}func b(UInt=1 + 1 + 1 + 1 as?Int){{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{(_{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
Expand Down
3 changes: 1 addition & 2 deletions ...uted-at-swift-lib-ast-type-cpp-1349.swift → ...uted-at-swift-lib-ast-type-cpp-1349.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{{{{func a(UInt=1 + 1 as?Int){{{{{{A{{{{{{{{{{{{{{{{{{{{{{{{
3 changes: 1 addition & 2 deletions ...uted-at-swift-lib-ast-type-cpp-1349.swift → ...uted-at-swift-lib-ast-type-cpp-1349.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
func d(UInt=_=1 + 1 + 1 as?Int){guard let c=()a=1 1 guard let{p.a{f=1?It{{{[{{{{{{P{_.s{{{&({{b
4 changes: 1 addition & 3 deletions ...s/28691-result-case-not-implemented.swift → ...d/28691-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{s?init(UInt=1 + 1 as?Int){
4 changes: 1 addition & 3 deletions ...s/28694-result-case-not-implemented.swift → ...d/28694-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{P{}func b(UInt=1 + 1 as?Int){
6 changes: 1 addition & 5 deletions ...hecktype-swift-type-swift-sourceloc.swift → ...hecktype-swift-type-swift-sourceloc.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// RUN: not --crash %target-swift-frontend %s -emit-ir

// Temporarily disabled
// REQUIRES: SR-4219

// RUN: not %target-swift-frontend %s -emit-ir
{{extension{init(UInt=_=1 + 1 as?Int?Int){var f=nil?Int
4 changes: 1 addition & 3 deletions ...cantype-out-of-a-non-canonical-type.swift → ...cantype-out-of-a-non-canonical-type.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior

// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{func c(UInt=1 + 1 as?Int){b
4 changes: 1 addition & 3 deletions ...cantype-out-of-a-non-canonical-type.swift → ...cantype-out-of-a-non-canonical-type.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: asserts
// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{ struct c{func ulntatin(UInt=1 + 1 as?Int){a{a
3 changes: 1 addition & 2 deletions ...702-swift-typebase-getcanonicaltype.swift → ...702-swift-typebase-getcanonicaltype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{extension{func 丏(UInt=1 + 1 + 1 as?Int){a
3 changes: 1 addition & 2 deletions ...710-swift-typebase-getdesugaredtype.swift → ...710-swift-typebase-getdesugaredtype.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// RUN: not --crash %target-swift-frontend %s -emit-ir
// REQUIRES: deterministic-behavior
// RUN: not %target-swift-frontend %s -emit-ir
protocol A.init(UInt=_=1 + 1){{let c{extension{lazy var f={
4 changes: 1 addition & 3 deletions ...s/28714-result-case-not-implemented.swift → ...d/28714-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
{extension{func a(UInt=1 + 1 as?Int){a
4 changes: 1 addition & 3 deletions ...s/28717-result-case-not-implemented.swift → ...d/28717-result-case-not-implemented.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: deterministic-behavior
// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
A:{ struct A{func a(UInt=1 + 1 + 1 + 1 as?Int){
2 changes: 1 addition & 1 deletion ...erarena-no-constraint-solver-active.swift → ...erarena-no-constraint-solver-active.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors

// REQUIRES: asserts
// RUN: not --crash %target-swift-frontend %s -emit-ir
// RUN: not %target-swift-frontend %s -emit-ir
:{func t(UInt=1 + 1 + 1 as?Int){[.s
nil?Int