[cxx-interop] Enable -verify-additional-file tests on Windows #80694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
|
Gonna let this sit in draft until some CI results come back. |
|
@swift-ci please test |
These previously failed because they used '/' as the path separator
instead of '\'. While both are accepted on Windows, the latter is
preferred and used to construct new paths, such as the path of imported
header files. This inconsistency led to distinct buffer ID numbers being
created (since paths are not canonicalized in BufferIdentIDMap), leading
-verify to fail to associate the error emitted from the included file
with the error expected in the -verify-additional-file file.
This patch re-enables these tests but uses %{fs-sep} in place of '/', to
ensure the appropriate path separator is used for the platform where the
test is run.
rdar://148928101
j-hui
force-pushed
the
fix-verify-additional-file-windows
branch
from
42a567c to
8ff4d94
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Apr 10, 2025
egorzhdan
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These previously failed because they used '/' as the path separator instead of ''. While both are accepted on Windows, the latter is preferred and used to construct new paths, such as the path of imported header files. This inconsistency led to distinct buffer ID numbers being created (since paths are not canonicalized in BufferIdentIDMap), leading -verify to fail to associate the error emitted from the included file with the error expected in the -verify-additional-file file.
This patch re-enables these tests but uses %{fs-sep} in place of '/', to ensure the appropriate path separator is used for the platform where the test is run.
rdar://148928101