[CoroutineAccessors] Use yield_once_2 on Darwin and Linux. #80701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
approved these changes
Apr 9, 2025
nate-chandler
force-pushed
the
rdar148941214
branch
from
de493cf to
4317efc
Compare
Now that coroutine kind (and consequently ABI) for the accessors is keyed off a SIL option, it's no longer possible to read whether a given SILFunction arose from a read/modify coroutine just by checking its coroutine kind. Regardless of ABI, read/modify coroutines may only unwind (i.e. are only permitted not to "run to completion") if the relevant experimental (soon to be deleted) feature is enabled.
nate-chandler
force-pushed
the
rdar148941214
branch
from
4317efc to
b76a76b
Compare
|
@swift-ci please test |
nate-chandler
requested review from
eeckstein,
rjmccall,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key functions' coroutine kind off the platform and provide optional flags for overriding.
rdar://148941214