[6.2] swift-demangle: fix a crash for invalid input #80704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Apr 10, 2025
eeckstein
commented
- Explanation: When fed with invalid input, the swift-demangle tool crashed. This change adds some bounds checks in the node printer to fix it.
- Risk: Low. It only affects the swift-demangle tool.
- Testing: Tested by a lit test.
- Issue: rdar://148754959
- Reviewer: @al45tair
- Main branch PR: swift-demangle: fix a crash for invalid input #80666
When fed with invalid input, the swift-demangle tool crashed. rdar://148754959
|
@swift-ci test |
tbkka
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.