[6.2][cxx-interop] Diagnose Escapable C++ types with non-escapable fields #80710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds Explanation: In Swift, Escapable types cannot have non-escapable stored properties. Unfortunately, these checks could be circumvented via C++ interop, constructing invalid Swift code. This patch errors out on importing C++ code of this shape. Issue: rdar://148899224 Risk: Low, the fix is fairly targeted to the affected scenario. Testing: Added tests to test suite Original PR: #80671 Reviewer: John Hui
Xazax-hun
changed the title
|
@swift-ci please test |
Xazax-hun
added
🍒 release cherry pick
j-hui
approved these changes
Apr 12, 2025
DougGregor
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In Swift, Escapable types cannot have non-escapable stored properties. Unfortunately, these checks could be circumvented via C++ interop, constructing invalid Swift code. This patch errors out on importing C++ code of this shape.
Issue: rdar://148899224
Risk: Low, the fix is fairly targeted to the affected scenario.
Testing: Added tests to test suite
Original PR: #80671
Reviewer: John Hui