[6.2][Test][Concurrency] Fix isIsolatingCurrentContext tests #80747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests can fail when testing on an older OS version than the one that will ship with Swift 6.2. Fix by disabling availability checking. rdar://148986812
|
@swift-ci please test |
hborla
approved these changes
Apr 10, 2025
|
|
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These tests can fail when testing on an older OS version than the one that will ship with Swift 6.2. Fix by disabling availability checking.
Details: Since tests may run on an OS that correspond to an older Swift runtime, and if the build has real availability values and not the 9999 hardcoded ones, the
#if availabletest will fail, and thus not execute the code guarded by it. The CHECK lines are still checked, and since no code executed, these will all fail.Scope/Impact: Test only change
Risk: Low, test only
Testing: Verified the tests
Reviewed by: @ktoso (I reviewed, this is @al45tair's patch)
Original PR: #80720
Radar: rdar://148986812