[6.2][SUA][IRGen] Add stub for swift_coroFrameAlloc that weakly links against the runtime function #80769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nst the runtime function (#79889) * [SUA][IRGen] Add stub for swift_coroFrameAlloc that weakly links against the runtime function This commit modifies IRGen to emit a stub function `__swift_coroFrameAllocStub` instead of the newly introduced swift-rt function `swift_coroFrameAlloc`. The stub checks whether the runtime has the symbol `swift_coroFrameAlloc` and dispatches to it if it exists, uses `malloc` otherwise. This ensures the ability to back deploy the feature to older OS targets. rdar://145239850 (cherry picked from commit 5e2f20b)
|
@swift-ci test |
t-rasmud
added
🍒 release cherry pick
|
@swift-ci test Linux platform |
t-rasmud
changed the title
tbkka
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies IRGen to emit a stub function
__swift_coroFrameAllocStubinstead of the newly introduced swift-rt functionswift_coroFrameAlloc. The stub checks whether the runtime has the symbolswift_coroFrameAllocand dispatches to it if it exists, usesmallocotherwise. This ensures the ability to back deploy the feature to older OS targets.rdar://145239850
[SUA][IRGen] Add stub for swift_coroFrameAlloc that weakly links against the runtime function #79889
The risk is low because we ran SWBs to test that
swift_coroFrameAllocwhen the symbol is available.swift_coroFrameAllocsymbol is not found, the stub falls back to editingmallocRan the following SWBs to test changes and found no regressions:
rdar://148941793 (TMO SWB (Apr 9) with rt)
rdar://149082640 (TMO reverted rt)
aschwaighofer