[TypeChecker] Allow closures to assume nonisolated(nonsending)
#80872
+111
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always infer `nonisolated(nonsending)` from context directly on a closure unless the closure is marked as `@concurrent`, otherwise the closure is not going to get correct isolation and going to hop to the wrong executor in its preamble. Resolves: rdar://149107104
…t actor Closures that are caller isolated used to still hop to the generic executor, which is incorrect.
|
@swift-ci please test |
ktoso
approved these changes
Apr 17, 2025
| func testThatClosuresAssumeIsolation(fn: inout nonisolated(nonsending) (Int) async -> Void) { | ||
| // CHECK-LABEL: sil private [ossa] @$s21attr_execution_silgen31testThatClosuresAssumeIsolation2fnyySiYaYCcz_tFyyYaYCcfU_ : $@convention(thin) @async (@sil_isolated @sil_implicit_leading_param @guaranteed Optional<any Actor>) -> () | ||
| // CHECK: bb0([[EXECUTOR:%.*]] : @guaranteed $Optional<any Actor>): | ||
| // CHECK: hop_to_executor [[EXECUTOR]] |
|
Hmm the callActorFromStartSynchronousTask case failed in startSynchronously.swift, but that's likely a wrong test since we're correcting behavior here tbh... I'll see what to do about that test, we will be changing it a lot anyway to account for SE evolution |
|
Hmm the test is actually a bit racy, I attempted to improve it by making sure the called func suspends, which should give us the expected result consistently. |
|
@swift-ci please smoke test |
hborla
approved these changes
Apr 17, 2025
|
This has unblocked #80753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always infer
nonisolated(nonsending)from context directly on a closure unless the closure is marked as@concurrent, otherwise the closure is not going to get correct isolation and going to hop to the wrong executor in its preamble.Resolves: rdar://149107104