[6.2][AST] ASTPrinter: Improvements to specifier and attribute printing #80892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `nonisolated(nonsending)` parameter specifier is present mark the declaration as caller isolated. (cherry picked from commit 9bc96d4)
…ecifier first This avoids any possible positioning issues between specifiers and attributes. (cherry picked from commit 6662a48)
All of the `inout` types are implicitly `@escaping`. (cherry picked from commit ee38182)
… and specifiers as keywords (cherry picked from commit e302d73)
(cherry picked from commit 4fd4c00)
hborla
approved these changes
Apr 17, 2025
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
ktoso
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #80843
Explanation:
Fixes positioning of
nonisolated(nonsending)and other specifiers when printed in swift interfaces. Makes sure that specifiers are always printed before attributes (how parser expects the order to be) and that attributes are printed as attributes.@escapingif parameter isinoutnonisolated(nonsending)as a first specifierMain Branch PR: [AST] ASTPrinter: Improvements to specifier and attribute printing #80843
Risk: Low (The change to
nonsisolated(nonsending)printing has to source compatibility impact because no existing swift interfaces have that attribute printed yet. When it comes to the rest - mixing of specifiers and attribute would have caused failures already and there could be no existing interface files that could regress due to this change).Reviewed By: @xymus @ktoso
Testing: Added new tests to the test suite.