Skip to content

[SymbolGraphGen] fix AvailabilityFilter test to be resilient against path names #80899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

QuietMisdreavus
Copy link
Contributor

The test added in #80778 checked the symbol graph to make sure it didn't include certain platforms' availability information when it was being screened out. However, it accomplished this by checking against the string macOS, which seems to have broken tests for swift-syntax since that string is also present in file paths. This PR updates the test to specifically check for "domain": "[os]" instead so that it avoids hitting the file path as a false positive.

@xedin xedin enabled auto-merge April 17, 2025 22:05
@shahmishal shahmishal disabled auto-merge April 17, 2025 22:06
@xedin xedin merged commit f89dcf7 into main Apr 17, 2025
@xedin xedin deleted the vgm/fix-availability-test branch April 17, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants