-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[DNM] Revert #80925 and #80749 to check if they are the cause of source compatibility regressions #80932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constant values importing logic" This reverts commit d704989.
…ues.swift to fix Windows CI test failure" This reverts commit 0319aa4.
… CGFloats when importing const values" This reverts commit 26cc36b.
… decls, adjust C++ lit tests" This reverts commit 8e6071e.
This reverts commit dc65773.
…enum types" This reverts commit 936e911.
…_values.swift + ClangImporter/const_values_cxx.swift" This reverts commit ec24b74.
This reverts commit a39f60b.
@swift-ci please test source compatibility |
@kubamracek looks like Alamofire and kommander do succeed with the changes reverted. |
Alamofire failure is:
|
Kommander:
|
I think I have a fix here: #80940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.