Skip to content

[🍒 6.2] Fix String interpolation accepts invalid argument label syntax without expression #80950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kntkymt
Copy link
Contributor

@kntkymt kntkymt commented Apr 21, 2025

🍒 #80928

Explanation: The patch from #80928 fixes false-negative on invalid syntax related to String Interpolation with trailing comma: #80927.

"\(1, diag:)" // should be compile error.

Scope: Parser/syntax, related to String Interpolation with trailing comma. won't break existing code that has valid syntax.

Issues: #80927

Testing: Added test to test suite

Risk: Low. the compiler only fixes false-negative on invalid syntax.

Original PRs: #80928

Reviewers: @rintaro

@rintaro
Copy link
Member

rintaro commented Apr 21, 2025

@swift-ci Please test

@rintaro
Copy link
Member

rintaro commented Apr 21, 2025

@kntkymt Not strictly necessary, but when cherry-picking to a release branch in this repo, cherry-pick -x would be appreciated.

@kntkymt
Copy link
Contributor Author

kntkymt commented Apr 21, 2025

I see (sorry), thanks for letting me know, will use it next time 😃

@bnbarham
Copy link
Contributor

@swift-ci please test

@bnbarham bnbarham added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 21, 2025
@rintaro rintaro merged commit c9a1b9d into swiftlang:release/6.2 Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants