Sema: Improve MemberImportVisibility diagnostics for cross import overlays #80972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…rlays. When `MemberImportVisibility` is enabled and a declaration from a cross import overlay is diagnosed because it has not been imported, suggest imports of the declaring and bystanding modules instead of the cross import overlay module (which is an implementation detail). Resolves rdar://149307959.
tshortli
force-pushed
the
member-import-visibility-cross-import-overlay
branch
from
296a8a3 to
9e67cf0
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
Apr 22, 2025
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
MemberImportVisibilityis enabled and a declaration from a cross import overlay is diagnosed because it has not been imported, suggest imports of the declaring and bystanding modules instead of the cross import overlay module (which is an implementation detail).Resolves rdar://149307959.