Skip to content

LifetimeDependenceScopeFixup: handle returning dependent Optional #80979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 22, 2025

Add support for returnValue phis (e.g. to return an Optional .some or .none).

Fixes rdar://149397018 (Wrapping non escapable in an Optional
(or any copy lifetime wrapper) is an escape)

Add support for returnValue phis (e.g. to return an Optional .some or .none).

Fixes rdar://149397018 (Wrapping non escapable in an Optional
(or any copy lifetime wrapper) is an escape)
@atrick atrick requested a review from eeckstein as a code owner April 22, 2025 05:36
@atrick atrick requested a review from meg-gupta April 22, 2025 05:37
@atrick
Copy link
Contributor Author

atrick commented Apr 22, 2025

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Apr 22, 2025

Unrelated RegexBuilder failure
error: undefined reference to '$sSy12RegexBuilderSs11SubSequenceRtzrlE5split9separator9maxSplits25omittingEmptySubsequencesSaySsGSS_SiSbtF'

@atrick
Copy link
Contributor Author

atrick commented Apr 22, 2025

@swift-ci smoke test

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atrick
Copy link
Contributor Author

atrick commented Apr 22, 2025

@swift-ci smoke test linux

@atrick
Copy link
Contributor Author

atrick commented Apr 22, 2025

@swift-ci smoke test windows

@atrick atrick merged commit 93ad267 into swiftlang:main Apr 23, 2025
4 of 5 checks passed
@atrick atrick deleted the rdar149397018-optional-return branch April 23, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants