[Caching] Improve diagnostics around swift caching #81007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
cachemeifyoucan
force-pushed
the
eng/PR-145676736
branch
from
447d43a to
35f20e3
Compare
|
@swift-ci please smoke test |
|
ping for a review. NFC, just diagnostic changes. |
benlangmuir
reviewed
Apr 30, 2025
Improve diagnostics message for swift caching build by trying to emit the diagnostics early when there is more context to differentiate the different kind of problems. After the improvement, CAS Error should be more closer to when there is functional problem with the CAS, rather than mixing in other kinds of problem (like scanning dependency failures) when operating with a CAS. rdar://145676736
cachemeifyoucan
force-pushed
the
eng/PR-145676736
branch
from
35f20e3 to
226552b
Compare
|
@swift-ci please smoke test |
benlangmuir
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve diagnostics message for swift caching build by trying to emit the diagnostics early when there is more context to differentiate the different kind of problems.
After the improvement, CAS Error should be more closer to when there is functional problem with the CAS, rather than mixing in other kinds of problem (like scanning dependency failures) when operating with a CAS.
rdar://145676736