[SwiftCore]: Don't always clobber memory #81010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
mikeash,
al45tair,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please test |
compnerd
approved these changes
Apr 22, 2025
mikeash
approved these changes
Apr 22, 2025
etcwilde
force-pushed
the
ewilde/runtime-fix-clobbered-memories
branch
from
3d4eaf7 to
41fdd42
Compare
The new build system set `SWIFT_RUNTIME_CLOBBER_FREED_OBJECTS` to 0. Unfortunately, the check in the Swift runtime used `#ifdef`, so even though it was turned off, it was actually enabled in some cases. Fixing the issue in the build system as well as switching the check to verify that value of `SWIFT_RUNTIME_CLOBBER_FREED_OBJECTS` is taken into account in the sources. C/C++ implicitly defines macro values to 1 when set without a value and 0 when it is not set. Also making the hex a bit more recognizable and grep'able by including it as a comment. Fixes: rdar://149210738
etcwilde
force-pushed
the
ewilde/runtime-fix-clobbered-memories
branch
from
41fdd42 to
6f39a52
Compare
|
@swift-ci please test |
|
|
@swift-ci please test macOS |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new build system set
SWIFT_RUNTIME_CLOBBER_FREED_OBJECTSto 0. Unfortunately, the check in the Swift runtime used#ifdef, so even though it was turned off, it was actually enabled in some cases.Fixing the issue in the build system as well as switching the check to verify that value of
SWIFT_RUNTIME_CLOBBER_FREED_OBJECTSis taken into account in the sources. C/C++ implicitly defines macro values to 1 when set without a value and 0 when it is not set.Also making the hex a bit more recognizable and grep'able by including it as a comment.
Fixes: rdar://149210738