[cxx-interop] Reenable C++ benchmarks #81024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro and
eeckstein
as code owners
Xazax-hun
force-pushed
the
gaborh/fix-cpp-benchmarks
branch
from
ca26019 to
43b828f
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please benchmark |
|
Not 100% sure yet if this is a solution. Is it possible that the span back-deployment has not reached the CI machines yet that are doing the benchmarks? Edit: probably #82309 solved this. |
The underlying issue was fixed in #82309 rdar://149402670
Xazax-hun
force-pushed
the
gaborh/fix-cpp-benchmarks
branch
from
43b828f to
3dda301
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please benchmark |
egorzhdan
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue was fixed in #82309
rdar://149402670