Runtimes: manually adjust the library prefix for core,Concurrency #81039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These libraries use C++ as the linker language which will prevent `CMAKE_STATIC_LIBRARY_PREFIX_Swift` from impacting them. Wire this property to the target manually so that it takes effect. This is primarily meant to support Windows, where we use a non-standard library prefix for static libraries mirroring the behaviour of the language runtimes (i.e. ucrt, vcruntime, msvcrt).
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
approved these changes
Apr 23, 2025
|
macOS failure: |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These libraries use C++ as the linker language which will prevent
CMAKE_STATIC_LIBRARY_PREFIX_Swiftfrom impacting them. Wire this property to the target manually so that it takes effect. This is primarily meant to support Windows, where we use a non-standard library prefix for static libraries mirroring the behaviour of the language runtimes (i.e. ucrt, vcruntime, msvcrt).