6.2: [MoveOnly] Fix consumption of opened existentials. #81044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before adding a new parameter to the function being called.
For now, it is unused.
Enable walking into `TypeOffsetSizePair`s from an existential into an archetype. And set the access kind on `open_existential_addr` instructions which are the sources of rewritten `copy_addr`s to mutable. rdar://141279635
|
@swift-ci please test |
tbkka
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: During move checking, recognize an existential archetype as a child type of an existential.
The move checkers deal in aggregates and need to handle consumption of children. In some sense, an existential archetype is a child of an existential. Encode this relationship into the utility that walks into child types.
Scope: Affects code involving move-only existentials
Issue: rdar://141279635
Original PR: #81015
Risk: Low.
Testing: Added test.
Reviewer: Andrew Trick ( @atrick )