Skip to content

[6.2🍒] SILOptimizer: Disable invalid passes in C++-only compiler #81050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

etcwilde
Copy link
Member

Cherry-Pick of #80920

The SimplifyCFG and LoopRotate passes result in verification failures when built in a compiler that is not built with Swift sources enabled.

  • Scope: Disables optimizers passes in C++-only compiler for bootstrapping purposes. Has no impact on full Swift compiler build.
  • Risk: Low. This change has no impact in build environments where a Swift compiler is available.
  • Reviewers: @eeckstein
  • Testing: PR testing -- Full PR testing fails if passes are accidentally disabled.

Fixes: rdar://146357242

(cherry picked from commit bca1378)

The SimplifyCFG and LoopRotate passes result in verification failures
when built in a compiler that is not built with Swift sources enabled.

 - Scope: Disables optimizers passes in C++-only compiler for
   bootstrapping purposes. Has no impact on full Swift compiler build.
 - Risk: Low. This change has no impact in build environments where a
   Swift compiler is available.
 - Reviewers: @eeckstein
 - Testing: PR testing -- Full PR testing fails if passes are
   accidentally disabled.

Fixes: rdar://146357242

(cherry picked from commit bca1378)
@etcwilde etcwilde added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 23, 2025
@etcwilde etcwilde requested a review from a team as a code owner April 23, 2025 21:15
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde etcwilde merged commit 9fd85fd into swiftlang:release/6.2 Apr 24, 2025
5 checks passed
@etcwilde etcwilde deleted the ewilde/6.2-cxxonly-disable-broken-passes branch April 25, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants