Skip to content

[Runtime] Shrink RemanglerBuffer's SubstitutionEntry. #81084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Apr 24, 2025

We stack-allocate 512 of these entries for a temporary cache, so the entry size matters a great deal. Shrink it from 3 words to 2 by storing treatAsIdentifier in the low bit of the node pointer.

rdar://149685318

We stack-allocate 512 of these entries for a temporary cache, so the entry size matters a great deal. Shrink it from 3 words to 2 by storing treatAsIdentifier in the low bit of the node pointer.

rdar://149685318
@mikeash mikeash requested a review from al45tair April 24, 2025 19:45
@mikeash mikeash requested a review from rjmccall as a code owner April 24, 2025 19:45
@mikeash
Copy link
Contributor Author

mikeash commented Apr 28, 2025

@swift-ci please test

@mikeash mikeash enabled auto-merge April 28, 2025 16:28
@mikeash mikeash merged commit 190a9c9 into swiftlang:main Apr 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants