AST: Filter out some Obj-C overrides when MemberImportVisibility is enabled #81089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
force-pushed
the
member-import-visibility-objc-overloads-in-extensions-take-2
branch
from
b54573f to
13cffde
Compare
|
@swift-ci please test |
…nabled. Unlike in Swift, Obj-C allows method overrides to be declared in extensions (categories), even outside of the module that defines the type that is being extended. When MemberImportVisibility is enabled, these overrides must be filtered out to prevent them from hijacking name lookup and causing the compiler to insist that the module that defines the extension be imported. Resolves rdar://145329988.
tshortli
force-pushed
the
member-import-visibility-objc-overloads-in-extensions-take-2
branch
from
13cffde to
039974a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
tshortli
deleted the
member-import-visibility-objc-overloads-in-extensions-take-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in Swift, Obj-C allows method overrides to be declared in extensions (categories), even outside of the module that defines the type that is being extended. When
MemberImportVisibilityis enabled, these overrides must be filtered out to prevent them from hijacking name lookup and causing the compiler to insist that the module that defines the extension be imported.This is a second attempt of #80563. This time,
removeOverriddenDecls()has been updated to consistently traverse the entire chain of overridden methods to account for gaps created by filtering.Resolves rdar://145329988.