[Bridging PCH] Only emit deps for CompileJobActions rdar://31056789 #8109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 3.1 branch variant of #8097 , original text follows:
Undo a bug (accidentally introduced in #7944 / fae468f) wherein we generate .d and .swiftdeps files for bridging PCH steps. The presence of these breaks an invariant that only CompileJobActions are supposed to have such depfiles, which in turn causes an attempted cast to go wrong. This bad cast traps in an assertions-build. In non-assertions builds it's a UMR that may cause a miscompile.
rdar://31056789