[cxx-interop] Proper conversions between MutableSpan and C++ span #81097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the initializers were missing and the other was crashing at runtime due to a faulty signature in the overlay. rdar://149846666
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
|
@swift-ci please smoke test |
Xazax-hun
pushed a commit
that referenced
this pull request
Apr 25, 2025
Explanation: One of the initializers were missing and the other was crashing at runtime due to a faulty signature in the overlay. Issue: rdar://149846666 Risk: Low, the fix is additive. Testing: Regression test added. Original PR: #81097 Reviewer:
|
@swift-ci please smoke test Windows |
j-hui
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the initializers were missing and the other was crashing at runtime due to a faulty signature in the overlay.
rdar://149846666