Skip to content

[6.2][Concurrency] Add nonisolated(nonsending) to completion lookup #81121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 26, 2025

Description: We didn't add the autocompletion for nonisolated(nonsending) while this combo of keywords was introduced, this fixes that missing IDE autocompletion.

Scope/Impact: Just adds which autocomplete we offer, now including "nonsending" which was added in 6.2.
Risk: Low, just adds a case to autocompletion
Testing: CI testing, added test covering this completion
Reviewed by: @xedin

Original PR: #81099
Radar:

@ktoso ktoso requested a review from a team as a code owner April 26, 2025 08:12
Seems we perhaps missed adding the completion for `nonsending` here?

cc @xedin

[IDE] Tests: That that `nonisolated` has `nonsending` completion
@ktoso ktoso force-pushed the pick-nonsending-completion-lookup branch from 1763d40 to 8d1429c Compare April 26, 2025 08:14
@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features swift 6.2 labels Apr 26, 2025
@ktoso
Copy link
Contributor Author

ktoso commented Apr 26, 2025

@swift-ci please test

@ktoso ktoso enabled auto-merge April 26, 2025 08:17
@ktoso ktoso merged commit c3bec29 into swiftlang:release/6.2 Apr 26, 2025
5 checks passed
@ktoso ktoso deleted the pick-nonsending-completion-lookup branch April 28, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants