Skip to content

[6.2] LifetimeDependence: fix a type checker crash on implicit init #81130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 28, 2025

When the type checker diagnoses an error on an implicit initializer,
return immediately before handling its parameter to avoid an assert.

(cherry picked from commit e9ac803)

main PR: #81129

When the type checker diagnoses an error on an implicit initializer,
return immediately before handling its parameter to avoid an assert.

(cherry picked from commit e9ac803)
@atrick atrick added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 28, 2025
@atrick atrick requested a review from a team as a code owner April 28, 2025 05:40
@atrick
Copy link
Contributor Author

atrick commented Apr 28, 2025

@swift-ci test

@atrick atrick requested a review from tbkka April 28, 2025 05:42
@atrick atrick enabled auto-merge April 28, 2025 05:42
@atrick
Copy link
Contributor Author

atrick commented Apr 28, 2025

This is blocked on a known memory corruption issue with
Concurrency/Reflection/reflect_task.swift

@atrick
Copy link
Contributor Author

atrick commented Apr 28, 2025

@swift-ci test macOS

@atrick
Copy link
Contributor Author

atrick commented Apr 29, 2025

More spurious failures:
Failed Tests (2):
lldb-api :: lang/swift/unknown_reference/TestSwiftUnknownReference.py
lldb-api :: lang/swift/unknown_self/TestSwiftUnknownSelf.py

@atrick
Copy link
Contributor Author

atrick commented Apr 29, 2025

@swift-ci test

@atrick atrick merged commit 3ca91b5 into swiftlang:release/6.2 Apr 30, 2025
5 checks passed
@atrick atrick deleted the 62-fix-default-init branch April 30, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants